Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update connector-tests.yml worfklow to use dev binary of airbyte-ci #131

Merged
merged 8 commits into from
Dec 6, 2024
Merged
34 changes: 13 additions & 21 deletions .github/workflows/connector-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -86,12 +86,10 @@ jobs:
# TODO: Re-enable once fixed
# - connector: source-zendesk-support
# cdk_extra: n/a
# TODO: These are manifest connectors and won't work as expected until we
# add `--use-local-cdk` support for manifest connectors.
# - connector: source-the-guardian-api
# cdk_extra: n/a
# - connector: source-pokeapi
# cdk_extra: n/a
- connector: source-the-guardian-api
cdk_extra: n/a
- connector: source-pokeapi
cdk_extra: n/a

name: "Check: '${{matrix.connector}}' (skip=${{needs.cdk_changes.outputs['src'] == 'false' || needs.cdk_changes.outputs[matrix.cdk_extra] == 'false'}})"
steps:
Expand Down Expand Up @@ -121,23 +119,17 @@ jobs:
repository: airbytehq/airbyte
ref: master
path: airbyte
- name: Test Connector
- name: Test connector
if: steps.no_changes.outputs.status != 'cancelled'
id: run-airbyte-ci-connector-test-pr
timeout-minutes: 90
env:
GCP_GSM_CREDENTIALS: ${{ secrets.GCP_GSM_CREDENTIALS }}
POETRY_DYNAMIC_VERSIONING_BYPASS: "0.0.0"
# TODO: Revert below to use `tools.airbyte-ci-binary.install` after Airbyte CI released:
run: |
cd airbyte
make tools.airbyte-ci-dev.install
airbyte-ci-dev connectors \
--name ${{matrix.connector}} \
--use-local-cdk \
test \
--fail-fast \
--skip-step qa_checks \
--skip-step connector_live_tests
uses: ./airbyte/.github/actions/run-airbyte-ci
with:
context: "pull_request"
subcommand: "--name ${{matrix.connector}} test --fail-fast --skip-step qa_checks --skip-step connector_live_tests"
# TODO remove me once local cdk is confirmed to work for manifest only connector
# We use a custom binary url to run the airbyte-ci version of this PR: https://github.com/airbytehq/airbyte/pull/48818
airbyte_ci_binary_url: https://storage.googleapis.com/dev-airbyte-cloud-connector-metadata-service/airbyte-ci/releases/ubuntu/f217461/airbyte-ci

- name: Evaluate Test Output
if: always() && steps.no_changes.outputs.status != 'cancelled'
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -201,3 +201,5 @@ optional_poetry_groups = ["dev"]
poetry_extras = ["file-based", "sphinx-docs", "vector-db-based"]
poe_tasks = ["check-ci"]
mount_docker_socket = true

#TODO revert me
Loading