Skip to content

Commit

Permalink
chore: pr review and cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
aaronsteers committed Dec 3, 2024
1 parent d7d1fda commit 192e905
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/declarative/decoders/noop_decoder.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class NoopDecoder(Decoder):
def is_stream_response(self) -> bool:
return False

def decode( # type: ignore[override]
def decode( # type: ignore[override] # Signature doesn't match base class
self,
response: requests.Response,
) -> Generator[Mapping[str, Any], None, None]:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

class AbstractFileBasedAvailabilityStrategy(AvailabilityStrategy):
@abstractmethod
def check_availability( # type: ignore[override]
def check_availability( # type: ignore[override] # Signature doesn't match base class
self,
stream: Stream,
logger: logging.Logger,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class DefaultFileBasedAvailabilityStrategy(AbstractFileBasedAvailabilityStrategy
def __init__(self, stream_reader: AbstractFileBasedStreamReader) -> None:
self.stream_reader = stream_reader

def check_availability( # type: ignore[override]
def check_availability( # type: ignore[override] # Signature doesn't match base class
self,
stream: AbstractFileBasedStream,
logger: logging.Logger,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ def get_access_token(self) -> str:
emit_configuration_as_airbyte_control_message(self._connector_config)
return self.access_token

def refresh_access_token( # type: ignore[override]
def refresh_access_token( # type: ignore[override] # Signature doesn't match base class
self,
) -> Tuple[str, str, str]:
response_json = self._get_refresh_access_token_response()
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ pytest-cov = "*"
pytest-httpserver = "*"
pytest-mock = "*"
requests-mock = "*"
# Stubs packages for mypy typing
types-requests = "^2.32.0.20241016"
types-python-dateutil = "^2.9.0.20241003"
types-pyyaml = "^6.0.12.20240917"
Expand Down

0 comments on commit 192e905

Please sign in to comment.