Introduce Mavericks core module #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move everything that could be Android platform agnostic into the core module. Part of airbnb#632
elihart
reviewed
Jun 16, 2022
Introduce `ExperimentalMavericksApi` annotation to repository declarations, to denote that repository is experimental API. Extract `MavericksBlockExecutions` out from `MavericksViewModelConfig`, as `MavericksViewModelConfig` resides in `mvrx` module. Replace `MavericksRepositoryConfigFactory` with `MavericksRepositoryConfigProvider` for simplicity. Fix docs in `mvrx-core` module
sav007
changed the title
elihart
reviewed
Jun 24, 2022
| @@ -30,6 +25,16 @@ fun assertMavericksDataClassImmutability( | |||
| ) { | |||
| require(kClass.java.isData) { "Mavericks state must be a data class! - ${kClass.simpleName}" } | |||
|
|
|||
| val disallowedFieldCollectionTypes = listOfNotNull( | |||
There was a problem hiding this comment.
seems like a good solution 👍
Return back `MavericksViewModel.viewModelScope` for backward compatibility.
gpeal
reviewed
Jun 28, 2022
elihart
approved these changes
Jul 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #635 +/- ##
==========================================
- Coverage 55.06% 47.81% -7.25%
==========================================
Files 53 49 -4
Lines 2508 2704 +196
Branches 326 289 -37
==========================================
- Hits 1381 1293 -88
- Misses 976 1279 +303
+ Partials 151 132 -19
Continue to review full report at Codecov.
|
|
@elihart fixed lint issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move everything that could be Android platform agnostic into the core module.
Part of #632