Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat appcompat as an api dependency #2507

Merged
merged 1 commit into from
May 29, 2024
Merged

Treat appcompat as an api dependency #2507

merged 1 commit into from
May 29, 2024

Conversation

jrodbx
Copy link
Contributor

@jrodbx jrodbx commented May 29, 2024

...since LottieAnimationView extends AppCompatImageView, therefore the latter is part of the former's ABI.

...since LottieAnimationView extends AppCompatImageView, therefore it's part of its ABI
@jrodbx jrodbx marked this pull request as ready for review May 29, 2024 18:04
Copy link

Snapshot Tests
API 23: Report Diff
API 31: Report Diff

@gpeal gpeal merged commit fb64a7f into airbnb:master May 29, 2024
7 checks passed
@jrodbx jrodbx deleted the jrod/2024-05-29/appcompat-api branch May 29, 2024 20:14
jbeta51 pushed a commit to jbeta51/lottie-android that referenced this pull request Jun 18, 2024
LottieAnimationView extends AppCompatImageView, therefore the latter is part of the former's ABI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants