Refactored the data structure in template and setData
JSON data.
#180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR refactored the data structure in template and
setData
JSON data.yarn start
oryarn build
), one of them is for development with full fields name, another is for production with shorten name. E.g.meta.props.className
=>m.p.className
could save more bundle size.Development:
Production (formatted):
type
/props
/children
and etc., are all stored in a standalone object namedmeta
. E.g.class="{{props.className}}"
=>class="{{meta.props.className}}"
.Why
mate
object could avoid some unexpected issue ( Value changes toundefined
doesn't work on Baidu template #179 ).How
Both
@goji/core
and@goji/cli
should be modified.I created a new function
getTemplateIds
that returns needed identifiers used by templates. This function can be accessed viaimport { unstable_getTemplateIds as getTemplateIds } from '@goji/core';
so every GojiJS packages could share it.Finally I tested this PR on internal large project and checked everything went well.