Fix implicit animationg bug #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brynbodayle I fixed another (related) issue with pinned days of the week. I was drawing them at weird positions due to the whole 3x visible bounds thing that I added for animated layout passes. The 2 new commits fix that + add unit tests for it. |
bryankeller
commented
Aug 30, 2023
| @@ -242,7 +248,7 @@ final class VisibleItemsProvider { | |||
|
|
|||
| // Handle pinned day-of-week layout items | |||
| if case .vertical(let options) = content.monthsLayout, options.pinDaysOfWeekToTop { | |||
| handlePinnedDaysOfWeekIfNeeded(yContentOffset: bounds.minY, context: &context) | |||
| handlePinnedDaysOfWeekIfNeeded(yContentOffset: offset.y, context: &context) | |||
There was a problem hiding this comment.
we don't want to use the extended bounds for this, otherwise we'll render these pinned items off screen
jpsoultanis
approved these changes
Aug 30, 2023
brynbodayle
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This fixes an issue that could cause the calendar to layout with an odd animation. Recently, we changed the way
layoutSubviewsworks - we check if we're currently in an animation closure, and if we are, we layout a larger region than what's currently visible so that offscreen items animate in / away correctly.This behavior change only makes sense if the reason we're in
layoutSubviewsis because of a call tosetContent(which will do some animation preparation). If we end up inlayoutSubviewsin an animation closure withoutsetContentgetting called first, then we didn't do any animation preparation insetContent, and the newlayoutSubviewsbehavior doesn't make sense anymore.The solution is to set a flag in
setContentto indicate that the next call tolayoutSubviewsshould use the new behavior for animated updates, rather than checking if we're in an animation closure (which could happen if a random part of code callslayoutIfNeededin an animation closure without also callingsetContentfirst).Related Issue
N/A
Motivation and Context
Found a bug in the Airbnb app
How Has This Been Tested
Example app, Airbnb app
Types of changes
Checklist