Issue/35/quantilespacing #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2016
drphilmarshall
approved these changes
Dec 9, 2016
| self.vals = (1.0/(len(self.quantiles)+1))/self.difs | ||
| #self.difs = self.quantiles[0][1:]-self.quantiles[0][:-1] | ||
| #self.mids = (self.quantiles[0][1:]+self.quantiles[0][:-1])/2. | ||
| self.mids = self.quantiles[0] |
There was a problem hiding this comment.
Much neater! Feel free to remove the commented out parts, they're in the history.
| """ | ||
| Computes an array of evenly-spaced quantiles from the truth. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| quants: ndarray, float | ||
| array of quantile locations as decimals |
There was a problem hiding this comment.
I see - you are punting the choice of quantpoints to the user. Fine! It would be good to come up with a good algorithm for setting the quantpoints, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #35 I added in support for custom quantile spacing and demonstrated its use in the demo notebook.
Even though I'm already making this pull request, I'm still considering revising the demo notebook to not alter the original example (as I did for this quick and dirty hacked in function) but instead to add it as a new example at the end before recomputing the KLD.