#316

#316 Use product version for user agent
aim42 · Jan 21, 2024 · f77eddd · f77eddd
1 parent fb40131
commit f77eddd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/gradle.properties b/gradle.properties
@@ -1,5 +1,3 @@
 // version now handled in build.gradle
-version=1.1.5
-
-
+version=1.1.7-SNAPSHOT
 
diff --git a/src/main/groovy/org/aim42/htmlsanitycheck/ProductVersion.groovy b/src/main/groovy/org/aim42/htmlsanitycheck/ProductVersion.groovy
@@ -19,8 +19,8 @@ public class ProductVersion {
             Properties props = new Properties()
             props.load(RESOURCE.openConnection().inputStream)
             return props.getProperty("version");
-        } catch (IOException E) {
-            logger.debug("ProductVersion cannot be obtained due to IOException.")
+        } catch (IOException e) {
+            logger.error("ProductVersion cannot be obtained due to IOException '{}'", e, e)
         }
         return "[unknown]";
     }

diff --git a/src/main/groovy/org/aim42/htmlsanitycheck/check/BrokenHttpLinksChecker.groovy b/src/main/groovy/org/aim42/htmlsanitycheck/check/BrokenHttpLinksChecker.groovy
@@ -1,6 +1,7 @@
 package org.aim42.htmlsanitycheck.check
 
 import org.aim42.htmlsanitycheck.Configuration
+import org.aim42.htmlsanitycheck.ProductVersion
 import org.aim42.htmlsanitycheck.collect.Finding
 import org.aim42.htmlsanitycheck.collect.SingleCheckResults
 import org.aim42.htmlsanitycheck.html.HtmlElement
@@ -191,7 +192,7 @@ class BrokenHttpLinksChecker extends Checker {
         // to avoid nasty 403 errors (forbidden), we set a referrer and user-agent
         //
         connection.setRequestProperty("Referer", "https://aim42.org");
-        connection.setRequestProperty("User-Agent", "Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0");
+        connection.setRequestProperty("User-Agent", "hsc/${ProductVersion.getVersion()}");
 
         // TODO followRedirects should be a configuration parameter
         // that defaults to false