Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added generate_projections for List and Dict #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

louisponet
Copy link

This PR automatically checks whether the projections List input to the Wannier90Calculation has all dicts, and if so constructs the OrbitalData from the list using generate_projections. Similarly, it solves an inconsistency when a Dict was passed to the projections input, and again generates the OrbitalData.

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #116 (e01a995) into develop (b9b0e38) will increase coverage by 0.10%.
The diff coverage is 86.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    76.01%   76.12%   +0.10%     
===========================================
  Files            9        9              
  Lines          834      846      +12     
===========================================
+ Hits           634      644      +10     
- Misses         200      202       +2     
Impacted Files Coverage Δ
aiida_wannier90/io/_write_win.py 90.44% <86.66%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9b0e38...e01a995. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants