Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organising your data (aka. groups) #364

Merged
merged 7 commits into from
Jul 2, 2021
Merged

Organising your data (aka. groups) #364

merged 7 commits into from
Jul 2, 2021

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Jun 28, 2021 •
edited
Loading

Closes #342

I've split this into 3 commits (for review purposes only):

  1. Improving the actual content - not much to do here, just very minor clarifications.
  2. Remove empty lines in code blocks.
  3. Try to update the text according to 👌 IMPROVE: Use consistent tense/perspective throughout tutorial #360.

P.S. I can't find information about who is in who's sections from the Google Drive, so I just put the @mbercx and @chrisjsewell as reviewers here...

@CasperWA CasperWA linked an issue Jun 28, 2021 that may be closed by this pull request
👌 IMPROVE: Module: Data - Organising your data #342
Closed
mbercx
mbercx requested changes Jul 1, 2021
View reviewed changes
Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CasperWA! 🙏 I've given the section a pass and left some suggestions/comments. Since we need to merge this tomorrow (or rather, today 😅 ), feel free to bypass comments that you think will take too much time to fix.

docs/sections/data/groups.md Outdated Show resolved Hide resolved
docs/sections/data/groups.md Outdated Show resolved Hide resolved
docs/sections/data/groups.md Outdated Show resolved Hide resolved
docs/sections/data/groups.md Show resolved Hide resolved
docs/sections/data/groups.md Outdated Show resolved Hide resolved
docs/sections/data/groups.md Outdated Show resolved Hide resolved
docs/sections/data/groups.md Outdated Show resolved Hide resolved
docs/sections/data/groups.md Outdated Show resolved Hide resolved
docs/sections/data/groups.md
```

:::{note}

In the terminal, paths that contain nodes are listed in bold
In the terminal, paths that contain nodes are listed in bold.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? I don't seem to notice this. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't actually check it now, but the code has bold=True? https://github.com/aiidateam/aiida-core/blob/develop/aiida/cmdline/commands/cmd_group.py#L448

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, i'll double check it during my pass, thanks!

docs/sections/data/groups.md Outdated Show resolved Hide resolved
CasperWA and others added 2 commits July 2, 2021 11:36
@CasperWA
Copy link
Contributor Author

CasperWA commented Jul 2, 2021

Thanks for the review @mbercx - I'll let you handle it from here as I'm out of time :/

@mbercx
Copy link
Member

mbercx commented Jul 2, 2021

Thanks for the review @mbercx - I'll let you handle it from here as I'm out of time :/

image

@mbercx mbercx self-requested a review July 2, 2021 09:50
mbercx
mbercx approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@mbercx mbercx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this show on the road! 🚀 Thanks for revising this section, @CasperWA!

@mbercx mbercx merged commit 0c32062 into aiidateam:tutorial-2021-intro-week Jul 2, 2021
@CasperWA CasperWA deleted the close_342_organising-data branch July 2, 2021 09:56
@ltalirz ltalirz mentioned this pull request Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramirezfranciscof ramirezfranciscof ramirezfranciscof left review comments

@mbercx mbercx mbercx approved these changes

@chrisjsewell chrisjsewell Awaiting requested review from chrisjsewell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

👌 IMPROVE: Module: Data - Organising your data
3 participants
@CasperWA @mbercx @ramirezfranciscof