Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to aiida v2.5 and optimade-python-tools 1.0 #527

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

eimrek
Copy link
Member

@eimrek eimrek commented Jan 25, 2024

Hi @CasperWA, I would really need some fixes that are in aiida v2.5.0 (namely, mutating nodes with iterall()) to enable the optimade api for some large DBs on materials cloud (would be great to have before submisison of the optimade paper).

However, aiida v2.5.0 migrated to pydantic 2 and therefore it looks like the optimade-python-tools dependency should also be upgraded to 1.0.

Additionally, aiida v2.5 removed the "legacy testing" that was used in this repo. This i managed migrate to the new format.

However, i am not able to adapt this repo to optimade-python-tools 1.0. No specific error is raised, but just the functionality is not correct (e.g. it re-calculates the optimade extras every time; there seem to be spurious optimade attributes in random places, etc).

Would be great if you could take a look! Feel free to contribute directly to this PR.

@CasperWA
Copy link
Collaborator

Indeed, the upgrade to pydantic v2 (and more importantly to OPTIMADE v1) is a large task.
Mainly due to the somewhat "hacky" way the OPTIMADE attributes are calculated by this package, stored, and handled --- it could be better. But alas.

I don't have much (if any) time to spend on this. Especially not at the moment. However, I may take a peek after hours in a couple of weeks.
If this is too late, feel free to take complete control and do whatever you wish here :) I would love to contribute and help where I can, but I am afraid this will take more time than I can afford currently.

@eimrek
Copy link
Member Author

eimrek commented Jan 31, 2024

thanks for the info @CasperWA. As it's a lot of work, I think for now, we might adapt a different approach (https://github.com/materialscloud-org/optimade-maker) for the larger DBs.

And also pragmatically, as maintaining this repo is a constant source of work (due to aiida-core getting updated), we might need to consider moving all the mcloud optimade APIs to a simpler approach. We'll discuss in the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants