Migrating to aiida v2.5 and optimade-python-tools 1.0 #527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @CasperWA, I would really need some fixes that are in aiida v2.5.0 (namely, mutating nodes with iterall()) to enable the optimade api for some large DBs on materials cloud (would be great to have before submisison of the optimade paper).
However, aiida v2.5.0 migrated to pydantic 2 and therefore it looks like the optimade-python-tools dependency should also be upgraded to 1.0.
Additionally, aiida v2.5 removed the "legacy testing" that was used in this repo. This i managed migrate to the new format.
However, i am not able to adapt this repo to optimade-python-tools 1.0. No specific error is raised, but just the functionality is not correct (e.g. it re-calculates the optimade extras every time; there seem to be spurious optimade attributes in random places, etc).
Would be great if you could take a look! Feel free to contribute directly to this PR.