-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: GHA: Docker workflow refactor #6388
Conversation
@unkcpz since you wrote these workflows, maybe it makes most sense if you review this? Happy to do it if you don't have the time |
Sure, I'll do the review when it is ready. |
@unkcpz I just realized, we're probably going to need an extra buildjet account for aiidateam org, right? |
Yes, it is run using a separated account. But I guess you don't access to the dashboard to set it? |
I don't think so, since I am not a member of aiidateam I don't think. But if it is already setup that's great. |
@sphuber do you think you could (temporarily) give me a push access to this repo? Otherwise this PR is hard to test. |
Done |
As mentioned in another thread (aiidalab/aiidalab-qe#730), since the test was run before by PR from forked repo, then I'd be a bit disappointed this functionality disappeared. There is an solution that we can use to allow to use the |
This is an analogous refactor that I did over at aiidalab-docker-stack, please see that PR for details. aiidalab/aiidalab-docker-stack#439
tl;dr This should both increase speed and robustness of the build, main due to: