Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fidis computer with ch-315 reservation (+ codes). #22

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

yakutovicha
Copy link
Contributor

No description provided.

@sphuber
Copy link

sphuber commented Nov 19, 2020

Just a high-level question on the scope of this repository that this PR triggered for me: this addition seems to me to be very specific as it targets an explicit allocation on a single machine, so only people with access to that allocation can use these configurations. I am not sure how many people this would service, but do we have any "limits" on what gets accepted here, or can anyone add any configuration? Could I add a configuration that is just useful for me alone, just to help me simplify configuring my AiiDA install on multiple machines? I am not sure if this has already been discussed and if there is a consensus @ltalirz

@yakutovicha
Copy link
Contributor Author

Just a high-level question on the scope of this repository that this PR triggered for me: this addition seems to me to be very specific as it targets an explicit allocation on a single machine, so only people with access to that allocation can use these configurations.

That is correct.

I am not sure how many people this would service, but do we have any "limits" on what gets accepted here, or can anyone add any configuration? Could I add a configuration that is just useful for me alone, just to help me simplify configuring my AiiDA install on multiple machines? I am not sure if this has already been discussed and if there is a consensus @ltalirz

My current understanding is that anyone can add any configuration. The purpose (again, my interpretation) is to simplify the computer/code setup as much as possible. So to me, that would be completely fine to have multiple daint setups for different daint reservations. Let's maybe have a separate issue to discuss the scope of this repo?

@yakutovicha
Copy link
Contributor Author

There is already an issue about that, actually: #8

@yakutovicha
Copy link
Contributor Author

As we agreed with @ltalirz I am going to go ahead with merging the PR, while the discussion initiated by @sphuber can be continued in the issue #8

@yakutovicha yakutovicha merged commit 3a2c639 into master Nov 19, 2020
@yakutovicha yakutovicha deleted the add/fidis-computer-course-reservation branch November 19, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants