Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in pytest #628

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Conversation

danielhollas
Copy link
Contributor

Added some ignores for deprecation warnings.

I have decided to remove the settings that turned warnings into hard errors, since it turned out to be too much of a hassle.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.61%. Comparing base (ae11a2b) to head (37189bd).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   83.61%   83.61%           
=======================================
  Files          16       16           
  Lines        3522     3522           
=======================================
  Hits         2945     2945           
  Misses        577      577           
Flag Coverage Δ
python-3.11 83.61% <ø> (ø)
python-3.9 83.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas
Copy link
Contributor Author

@edan-bainglass this should fix the test failures on your PRs.

@danielhollas danielhollas requested a review from unkcpz July 29, 2024 19:06
@danielhollas danielhollas enabled auto-merge (squash) August 7, 2024 10:36
@danielhollas danielhollas enabled auto-merge (squash) August 7, 2024 10:37
@danielhollas danielhollas merged commit de5f0cc into aiidalab:master Aug 7, 2024
11 checks passed
@danielhollas danielhollas deleted the fix-spglib branch August 7, 2024 11:49
@unkcpz
Copy link
Member

unkcpz commented Aug 8, 2024

Sorry for the late review, looks all good. If it supress warnings as expected, you can go ahead to merge without approve next time as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants