Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompResourcesWidget: do not raise when computer test fails #506

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

yakutovicha
Copy link
Member

fixes #418

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 74.03% and project coverage change: -0.11% ⚠️

Comparison is base (27ff1ba) 79.42% compared to head (91e0887) 79.31%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #506      +/-   ##
==========================================
- Coverage   79.42%   79.31%   -0.11%     
==========================================
  Files          27       27              
  Lines        3757     3834      +77     
==========================================
+ Hits         2984     3041      +57     
- Misses        773      793      +20     
Flag Coverage Δ
python-3.10 79.31% <74.03%> (-0.11%) ⬇️
python-3.8 79.35% <74.03%> (-0.11%) ⬇️
python-3.9 79.35% <74.03%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiidalab_widgets_base/databases.py 94.11% <ø> (+0.65%) ⬆️
aiidalab_widgets_base/computational_resources.py 69.73% <63.15%> (-0.82%) ⬇️
aiidalab_widgets_base/structures.py 74.96% <71.42%> (-0.19%) ⬇️
tests/test_computational_resources.py 100.00% <100.00%> (ø)
tests/test_structures.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on @yakutovicha! I have a couple of comments / suggestions.

btw: I think it would be super nice to have this functionality in the new Control page (list all computers in DB and have a button for testing them).

aiidalab_widgets_base/computational_resources.py Outdated Show resolved Hide resolved
aiidalab_widgets_base/computational_resources.py Outdated Show resolved Hide resolved
aiidalab_widgets_base/computational_resources.py Outdated Show resolved Hide resolved
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yakutovicha thanks, looks great! I have two final small suggestions.

aiidalab_widgets_base/computational_resources.py Outdated Show resolved Hide resolved
aiidalab_widgets_base/computational_resources.py Outdated Show resolved Hide resolved
@yakutovicha
Copy link
Member Author

@yakutovicha thanks, looks great! I have two final small suggestions.

Thanks for the suggestions. I also quickly tested them - all good.

Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@yakutovicha yakutovicha merged commit 5309f5d into master Sep 8, 2023
13 checks passed
@yakutovicha yakutovicha deleted the fix/do-not-except-if-computer-test-fails branch September 8, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug report: "test computer" raises when verdi command fails
2 participants