-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompResourcesWidget
: do not raise when computer test fails
#506
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 79.42% 79.31% -0.11%
==========================================
Files 27 27
Lines 3757 3834 +77
==========================================
+ Hits 2984 3041 +57
- Misses 773 793 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on @yakutovicha! I have a couple of comments / suggestions.
btw: I think it would be super nice to have this functionality in the new Control page (list all computers in DB and have a button for testing them).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yakutovicha thanks, looks great! I have two final small suggestions.
Co-authored-by: Daniel Hollas <[email protected]>
Thanks for the suggestions. I also quickly tested them - all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
fixes #418