Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(WIP) Tests: Make flaky instance life cycle test more robust. #97

Closed

Conversation

csadorf
Copy link
Member

@csadorf csadorf commented Feb 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #97 (edfe69d) into main (caf5db9) will increase coverage by 0.32%.
The diff coverage is 84.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   86.52%   86.85%   +0.32%     
==========================================
  Files           9        9              
  Lines         809      829      +20     
==========================================
+ Hits          700      720      +20     
  Misses        109      109              
Flag Coverage Δ
py-3.10 86.24% <82.35%> (-0.16%) ⬇️
py-3.7 ?
py-3.8 ?
py-3.9 86.80% <84.31%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/__main__.py 79.87% <66.66%> (-0.40%) ⬇️
aiidalab_launch/util.py 83.62% <66.66%> (+3.44%) ⬆️
aiidalab_launch/instance.py 91.33% <89.74%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caf5db9...edfe69d. Read the comment docs.

@csadorf
Copy link
Member Author

csadorf commented Feb 21, 2022

Superseded by #105 .

@csadorf csadorf closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant