Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aiidalab-launch profile remove accept multiple profiles #190

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Aug 14, 2023

fixes #173

This is based on #189

@unkcpz unkcpz added the block block label Aug 14, 2023
@unkcpz unkcpz force-pushed the fix/173/remove-multiple-profiles branch from 14e1b0c to d4d38c3 Compare August 14, 2023 13:16
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.02% ⚠️

Comparison is base (33c7a26) 86.32% compared to head (14e1b0c) 86.30%.

❗ Current head 14e1b0c differs from pull request most recent head d4d38c3. Consider uploading reports for the commit d4d38c3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #190      +/-   ##
==========================================
- Coverage   86.32%   86.30%   -0.02%     
==========================================
  Files           9        9              
  Lines         914      920       +6     
==========================================
+ Hits          789      794       +5     
- Misses        125      126       +1     
Flag Coverage Δ
py-3.10 86.19% <95.23%> (-0.02%) ⬇️
py-3.11 86.19% <95.23%> (-0.02%) ⬇️
py-3.8 86.15% <95.23%> (-0.02%) ⬇️
py-3.9 86.25% <95.23%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiidalab_launch/__main__.py 79.69% <95.23%> (+0.06%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz modified the milestone: v2023.1020 Aug 28, 2023
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this feature and its implementation makes sense to me. I'll do a detailed review once we merge #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can delete more than one profiles at one time
2 participants