-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump actions/artifact-upload to v4 #423
Conversation
I am ordering a request for the firewall rule in PSI, hope it will work. I'll keep this PR open for the test. |
Thanks @unkcpz. If the firewall rule does not fix it, we can use V3 action for arm and v4 for amd, and then focus on removing the artifacts entirely. |
Sadly no, from IT he said the TCP ports 80/443 is allowed by default, therefore no specific firewall rule is needed. |
I test it with aiida-core image which is a smaller one, all good. I think it is the problem of the action it self. See aiidateam/aiida-core#6228 |
I remove the compression setting and all works. There are two possibilities, 1) the artifact is too large 2) no compression causes the problem. |
I'll find time work on this this week anyway. |
That's a great find, thanks! The default compression level is 6, so you can try something between 1-5 to see if it works and is faster. In any case, v4 is much faster even with default compression level so this is worth merging anyway. |
This is a revert amendment of #419 which merged improperly with test commints.
action/checkout
action to v43.11
.docker.yml