Skip to content

Commit

Permalink
Move all extra apt packages to base, hopefully speeds up build
Browse files Browse the repository at this point in the history
  • Loading branch information
danielhollas committed Apr 30, 2024
1 parent 30eb7c9 commit 83b1975
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 13 deletions.
12 changes: 7 additions & 5 deletions stack/base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,19 @@ LABEL maintainer="AiiDAlab Team <[email protected]>"

USER root

# build-essential: includes GCC compilers that are needed when building
# pip packages from sources, which often seems to happen for pymatgen:
# https://pymatgen.org/installation.html#installation-tips-for-optional-libraries
# rsync: needed to support the new AiiDA backup command
# povray: rendering engine used in aiidalab-widgets-base
ENV EXTRA_APT_PACKAGES "curl povray rsync build-essential"
RUN apt-get update --yes && \
apt-get install --yes --no-install-recommends \
# for apps which need to install pymatgen:
# https://pymatgen.org/installation.html#installation-tips-for-optional-libraries
build-essential && \
apt-get install --yes --no-install-recommends ${EXTRA_APT_PACKAGES} && \
apt-get clean && rm -rf /var/lib/apt/lists/*

WORKDIR /opt/

ARG AIIDA_VERSION

# Pin shared requirements in the base environment.
# We pin aiida-core to the exact installed version,
# to prevent accidental upgrade or downgrade, that might
Expand Down
8 changes: 0 additions & 8 deletions stack/lab/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@ ENV DOCKER_STACKS_JUPYTER_CMD=notebook
USER root
WORKDIR /opt/

# Install additional system packages
RUN apt-get update --yes && \
apt-get install --yes --no-install-recommends \
curl \
povray \
&& apt-get clean \
&& rm -rf /var/lib/apt/lists/*

# Install aiidalab package
ARG AIIDALAB_VERSION
RUN mamba install --yes \
Expand Down

0 comments on commit 83b1975

Please sign in to comment.