Student #205

GabrieleMeoni · 2024-02-01T15:11:09Z

Description

Summary of changes

Merging students' contributions (cleaned by me) to main.

Resolved Issues

Issue Magnetic disturbances in attitude model #201
Issue Aerodynamic disturbances in Attitude Model #197
Issue Gravity disturbances in attitude model #196
Issue Attitude model #193
Issue Creating an geometric model #191
Issue Attitude Determination and Disturbances #190

How Has This Been Tested?

Refer to the specific tests included in the PR.
Issue #207 shall be taken into account in a separate PR.

…now in my own fork instead of Moana's)

…erence frame transformation function

…unction to form this transformation matrix)

…of floats, outputs: numpy arrays (needs to be reviewed in implementation)

…l and magnetic) on actor. started with set_attitude_model and attitude model class as well.

…access the I-matrix)

…of euler angles

…rect)

deleted redundant function (which I added myself)

pointing vector function

Gravity disturbances

Aerodynamic disturbances

pytest-asyncio

Student clean

review-notebook-app · 2024-02-01T15:11:16Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions · 2024-02-01T15:13:19Z

Coverage Report

File	Stmts	Miss	Cover	Missing
paseos
__init__.py	33	1	97%	49
paseos.py	148	12	92%	67–68, 145–146, 213, 228, 246, 255, 273, 304, 312–315
paseos/activities
activity_manager.py	43	3	93%	46, 74, 157
activity_processor.py	58	1	98%	121
activity_runner.py	62	10	84%	80–84, 104–113, 122–125
paseos/actors
actor_builder.py	223	33	85%	24–30, 33, 223–225, 252–254, 299–308, 339, 345, 493, 572–573, 588, 624, 671, 702, 714–718, 725–726, 733–734
base_actor.py	135	18	87%	85, 107, 123, 188, 228–230, 251, 260, 277, 298, 304–307, 313, 328, 383
ground_station_actor.py	15	3	80%	47–53
spacecraft_actor.py	108	14	87%	65–71, 79–85, 93–99, 198, 253, 262–265
spacecraft_body_model.py	52	4	92%	54, 89, 142, 157
paseos/attitude
attitude_model.py	89	2	98%	159, 168
disturbance_torques_utils.py	69	49	29%	46–222
paseos/central_body
central_body.py	73	6	92%	70, 179–180, 188–189, 258
is_in_line_of_sight.py	58	17	71%	106–123, 167, 174–187
mesh_between_points.py	35	2	94%	71, 79
sphere_between_points.py	26	8	69%	35–38, 48–51, 63–64
paseos/communication
find_next_window.py	20	15	25%	29–60
get_communication_window.py	23	18	22%	35–66
paseos/power
charge_model.py	16	1	94%	49
discharge_model.py	7	2	71%	22, 34
paseos/tests
activity_test.py	57	3	95%	90, 93–94
attitude_test.py	68	33	51%	93–129, 137–166
eclipse_test.py	10	1	90%	20
import_test.py	6	1	83%	13
init_test.py	8	1	88%	16
line_of_sight_test.py	62	4	94%	143–146
mesh_test.py	119	3	97%	118, 139, 147
thermal_model_test.py	30	1	97%	61
visualization_test.py	18	1	94%	28
paseos/utils
check_cfg.py	61	18	70%	31, 40, 46, 60–62, 67, 70–72, 75–77, 80–82, 98, 103
operations_monitor.py	71	3	96%	127–130
reference_frame_transfer.py	72	8	89%	108, 132, 240–242, 245–247
paseos/visualization
animation.py	18	6	67%	27–30, 35, 44
plot.py	9	3	67%	29–32
space_animation.py	215	23	89%	108–109, 124, 153–154, 188, 212–219, 225, 335, 358–360, 365, 374–375, 379, 415, 421–422, 453, 467–478
TOTAL	2655	328	88%

Tests	Skipped	Failures	Errors	Time
38	0 💤	0 ❌	0 🔥	1m 6s ⏱️

GabrieleMeoni · 2024-02-01T15:39:27Z

Issue #207 shall be taken into account in a separate PR.

gomezzz

Hey! Thanks for the cleaning. A few general comments in addition:

Please add short examples to the readme on using these models
Please add tests for reference frame conversions

For the rest see individual comments. :)

environment.yml

paseos/paseos.py

gomezzz · 2024-02-02T08:20:14Z

paseos/utils/reference_frame_transfer.py

Should we expose these feature to the users?

Logging missing in this file

gomezzz · 2024-02-02T08:21:23Z

paseos/utils/reference_frame_transfer.py

+import numpy as np
+
+
+def compute_transformation_matrix_eci_rpy(r, v):


I think this function is not used else, where so probably should be _compute_transformation_matrix_eci_rpy ?

There is no test for this function

paseos/tests/attitude_test.py

gomezzz · 2024-02-02T11:28:28Z

paseos/tests/attitude_test.py

+    assert np.round(sat1.temperature_in_K, 3) == 278.522
+
+
+def attitude_and_orbit_test():


wrong function name will not be run

gomezzz · 2024-02-02T11:29:03Z

paseos/tests/compare_communication_windows.py

wrong filename, has to end with _test or it will not be run

This file was included by mistake. I removed it.

gomezzz · 2024-02-02T11:29:37Z

paseos/tests/compare_communication_windows.py

+    return sentinel2B, maspalomas_groundstation
+
+
+def main():


will not be run since there is no function test_

Same as above.

gomezzz · 2024-02-02T11:31:37Z

paseos/tests/attitude_test.py

+    # Pointing vector from sat2 must not be rotated.
+    assert np.all(sat2.pointing_vector == np.array([-1.0, 0.0, 0.0]))
+    # Sat2 angular velocity in the body frame must stay zero:
+    assert np.all(sat2._attitude_model._actor_angular_velocity == np.array([0.0, 0.0, 0.0]))
+


only checking against trivial values, no actual check if the model produces correct values after e.g. 5 seconds of rotation

gomezzz · 2024-02-02T11:48:42Z

@rasmusmarak this is the work @GabrieleMeoni was mentioning in our call. Maybe, a good first step for you could be to create a small example notebook branching out of this to try out if you can compute the point on Earth's surface that a satelliteActor is pointing at? Ideally any problems and questions that arise during that can also be used in this PR as feedback. (Maybe @GabrieleMeoni could start by just adding a few sentences to the readme on how to use this to enable this?)

ghost · 2024-02-08T14:33:06Z

@rasmusmarak this is the work @GabrieleMeoni was mentioning in our call. Maybe, a good first step for you could be to create a small example notebook branching out of this to try out if you can compute the point on Earth's surface that a satelliteActor is pointing at? Ideally any problems and questions that arise during that can also be used in this PR as feedback. (Maybe @GabrieleMeoni could start by just adding a few sentences to the readme on how to use this to enable this?)

Sounds like a good start, I'll make sure to have a look at some initial notebook example! :-)

testing to be compliant to PASEOS).

Mr-Medina added 30 commits December 25, 2023 13:05

visualization code from examples, added thermal sim to get familiar (…

0610412

…now in my own fork instead of Moana's)

added Earth-Centered Inertial Frame (ECI) to Roll-Pitch-Yaw (RPY) ref…

fa7c867

…erence frame transformation function

added function to transform a vector from ECI to RPY. (also added a f…

01e9f74

…unction to form this transformation matrix)

added transformation matrix for RPY to body fixed frames

0242126

RPY to body fixed vector transformation functions added

86c55ca

v1 reference frame transfer file. cleaned up comments. inputs: lists …

e967cc4

…of floats, outputs: numpy arrays (needs to be reviewed in implementation)

Some cleaning up

53a8a34

added functions for user to identify disturbances (aero, gravitationa…

3993c6a

…l and magnetic) on actor. started with set_attitude_model and attitude model class as well.

created disturbance function file

07047e4

disturbance torque in attitude model

935ccc4

added case for zero euler angles (for ref frame transfers)

dfa12e5

initial onditions added

7cd2e31

Now able to call attitude in rad and deg from spacecraft actor.

e2b5351

added some dynamics to attitude model (not complete at all, needs to …

ce85d15

…access the I-matrix)

added more dynamics but I think its wrong (too simple)

eb4ba79

added has_attitude_model function

da4ba34

fixed error converting angles

3b214e4

added get_previous_position function

70c9a61

update atitude model in paseos

8ebaeea

fixing ref frame transformations

0a0cdad

TODO add pointing vector in inertial frame, updating extra component …

3cea066

…of euler angles

test file to see if model makes some sensez

608ef32

added function (might be deleted later) and fixed some stuff

dd38d0c

play python file to plot attitude. Works with plotting Nadir vector

62e97f5

commit attitude model before changing most of it (to get dynamics cor…

b4080b3

…rect)

play file fixed

8a67834

tried to apply correct dynamics. Not there yet

385ccb0

get_euler, angles can now also be negative. Right handed system applied

e28964e

Update base_actor.py

438eca6

deleted redundant function (which I added myself)

Update spacecraft_actor.py

4c0457b

pointing vector function

GabrieleMeoni and others added 10 commits February 1, 2024 13:20

Merge pull request #200 from aidotse/gravity-disturbances

e042180

Gravity disturbances

Merge branch 'student' into student_clean

e1fb6ac

Reformatting

3e117bd

Merge branch 'student' into aerodynamic-disturbances

333196d

Merge pull request #203 from aidotse/aerodynamic-disturbances

07d215b

Aerodynamic disturbances

Merging to PASEOS

a8032b1

Merge branch 'student' into student_clean

0dd8c56

Adding version constraint to pytest to enable running tests with

ad72734

pytest-asyncio

Reformatted with --line-length 100 option

f0e1a15

Merge pull request #204 from aidotse/student_clean

ef1d0d7

Student clean

GabrieleMeoni requested a review from gomezzz February 1, 2024 15:11

Gabriele Meoni added 3 commits February 1, 2024 16:31

Rm unwanted files.

a6ef070

Removing unwanted files.

ff192ef

Removing unwanted files.

bc5bfd1

gomezzz requested changes Feb 2, 2024

View reviewed changes

gomezzz mentioned this pull request Feb 9, 2024

Comms expansion #209

Open

1 task

Gabriele Meoni added 9 commits February 13, 2024 18:50

Applying first suggestions.

2e77458

Implementing other suggestions.

624966d

Removing aerodynamic modelling (it requires a major rewriting and

1d7df19

testing to be compliant to PASEOS).

Adding commits according to Pablo's suggestions.

5d184cf

Adding missing file.

363c11f

Fixing bug. Removing aerodisturbance test (model not implemented yet).

e9d8fce

Pleasing Flake.

020e53b

Removed unwanted test.

54a8621

Fixing wrong comments

9245ccb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Student #205

Student #205

GabrieleMeoni commented Feb 1, 2024 •

edited

Loading

review-notebook-app bot commented Feb 1, 2024

github-actions bot commented Feb 1, 2024 •

edited

Loading

GabrieleMeoni commented Feb 1, 2024

gomezzz left a comment

gomezzz Feb 2, 2024

gomezzz Feb 2, 2024

gomezzz Feb 2, 2024

gomezzz Feb 2, 2024

gomezzz Feb 2, 2024

GabrieleMeoni Feb 15, 2024

gomezzz Feb 2, 2024

GabrieleMeoni Feb 15, 2024

gomezzz Feb 2, 2024

gomezzz commented Feb 2, 2024

ghost commented Feb 8, 2024

		import numpy as np


		def compute_transformation_matrix_eci_rpy(r, v):

		assert np.round(sat1.temperature_in_K, 3) == 278.522


		def attitude_and_orbit_test():

Student #205

Are you sure you want to change the base?

Student #205

Conversation

GabrieleMeoni commented Feb 1, 2024 • edited Loading

Description

Resolved Issues

How Has This Been Tested?

review-notebook-app bot commented Feb 1, 2024

github-actions bot commented Feb 1, 2024 • edited Loading

GabrieleMeoni commented Feb 1, 2024

gomezzz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gomezzz commented Feb 2, 2024

ghost commented Feb 8, 2024

GabrieleMeoni commented Feb 1, 2024 •

edited

Loading

github-actions bot commented Feb 1, 2024 •

edited

Loading