Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attitude model v2 #198

Merged
merged 85 commits into from
Jan 30, 2024
Merged

Attitude model v2 #198

merged 85 commits into from
Jan 30, 2024

Conversation

Mr-Medina
Copy link
Collaborator

Description

Similar to pull request #194 .
Attitude model with outputs: actor attitude (roll, pitch & yaw angles) and user specified pointing vector. Now also outputs actor angular velocity vector and uses the actor moment of inertia from geometrical model from #195.

Attitude disturbances will be added in a later PR.

  • Angular velocity vector output
  • Geometrical model implemented

Resolved Issues

How Has This Been Tested?

Refer to "test_attitude_plotting.py" for visual reference of attitude model and response to changes of actor initial conditions.
Summary of changes.
More elaborate tests will follow.

Related Pull Requests

…of floats, outputs: numpy arrays (needs to be reviewed in implementation)
…l and magnetic) on actor. started with set_attitude_model and attitude model class as well.
deleted redundant function (which I added myself)
pointing vector function
Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check.

paseos/attitude/attitude_model.py Show resolved Hide resolved
paseos/attitude/attitude_model.py Show resolved Hide resolved
@Moanalengkeek Moanalengkeek mentioned this pull request Jan 27, 2024
1 task
Copy link
Collaborator

@GabrieleMeoni GabrieleMeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very small requests for clarification. The rest is all good.

paseos/tests/attitude_test.py Outdated Show resolved Hide resolved
actor_initial_angular_velocity=[0.0, 2 * np.pi / orbit_period, 0.0],
actor_pointing_vector_body=[0, 0, 1],
)
ActorBuilder.set_disturbances(sat1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check with the others what is supposed to happen when all disturbances are set?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add seperate disturbance tests in this file for every disturbance. This line could be deleted.

@Mr-Medina Mr-Medina added the tests Anything related to the tests label Jan 29, 2024
@Mr-Medina Mr-Medina mentioned this pull request Jan 29, 2024
1 task
@GabrieleMeoni GabrieleMeoni merged commit bb1056f into student Jan 30, 2024
0 of 3 checks passed
@GabrieleMeoni GabrieleMeoni deleted the attitude-model branch January 30, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature implementing a new feature physical-model All things involving some physical models tests Anything related to the tests visualization Code used to visualize the simulation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants