Skip to content

Commit

Permalink
ipc4: module: remove unused variable size structures
Browse files Browse the repository at this point in the history
struct ipc4_module_init_instance contains 4 structures at the end,
that aren't currently used in the firmware. Some of them like
struct ipc4_module_init_ext_data have a flexible array at the end
but can have further structures following them. Remove these
structures until any of them are needed, at which point they can be
re-added with proper size accounting.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
  • Loading branch information
lyakh authored and lgirdwood committed Mar 13, 2023
1 parent 11441d8 commit b541e41
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions src/include/ipc4/module.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
*/

/*
* This file contains structures that are exact copies of an existing ABI used
* by IOT middleware. They are Intel specific and will be used by one middleware.
*
* Some of the structures may contain programming implementations that makes them
* unsuitable for generic use and general usage.
*
Expand Down Expand Up @@ -145,11 +142,15 @@ struct ipc4_module_init_instance {
uint32_t _hw_reserved_2 : 2;
} r;
} extension;

struct ipc4_module_init_ext_init ext_init;
struct ipc4_module_init_ext_data ext_data;
struct ipc4_module_init_gna_config gna_config;
struct ipc4_module_init_data init_data;
/*
* The following objects are optional and follow this structure in this
* order provided the respective object bit is set in preceding object.
*
* struct ipc4_module_init_ext_init ext_init;
* struct ipc4_module_init_ext_data ext_data;
* struct ipc4_module_init_gna_config gna_config;
* struct ipc4_module_init_data init_data;
*/
} __attribute__((packed, aligned(4)));

/*!
Expand Down

0 comments on commit b541e41

Please sign in to comment.