Fix order of shape for unbatchify in POMO #98
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix order of argument
shape
forunbatchify
function in POMO Model.Types of changes
The original argument for
shape
was(n_start, n_aug)
, with which the shape of tensors will be changed to[batch_size, n_start, n_aug]
. But we want it to be[batch_size, n_aug, n_start]
so that it can mirror the batchify operation appropriately.Motivation and Context
Note that the bug will not harm your training procedure or maximum reward calculation, but it should be fixed because it is not what we wanted, and make debugging difficult.
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!
I found that there's no test code for POMO though :(