Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SMTWTP env #96

Merged
merged 2 commits into from
Oct 7, 2023
Merged

Add SMTWTP env #96

merged 2 commits into from
Oct 7, 2023

Conversation

henry-yeh
Copy link
Member

Description

Add SMTWTP env and its env embeddings.

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • New feature (non-breaking change which adds core functionality)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
rl4co/envs/__init__.py 95.00% <100.00%> (+0.26%) ⬆️
rl4co/models/nn/env_embeddings/context.py 97.70% <100.00%> (+0.26%) ⬆️
rl4co/models/nn/env_embeddings/dynamic.py 95.45% <ø> (ø)
rl4co/models/nn/env_embeddings/init.py 99.15% <100.00%> (+0.09%) ⬆️
rl4co/utils/test_utils.py 93.93% <100.00%> (+0.39%) ⬆️
rl4co/envs/smtwtp.py 98.63% <98.63%> (ø)

📢 Thoughts on this report? Let us know!.

@fedebotu
Copy link
Member

fedebotu commented Oct 7, 2023

Great job! Thanks for adding the tests, merging now 🚀

@fedebotu fedebotu merged commit d15c389 into ai4co:main Oct 7, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants