finalizing changelog

CHANGELOG.md

@@ -1,17 +1,19 @@
-# not released yet
+# v4.1.0 - 03 February 2021
 
-* Update simpleclient to 0.6.0
+* Update Prometheus simpleclient to v0.10.0
+* Additional metric `hystrix_thread_pool_property_value_maximum_size` (thanks to @victormferrara) (#29)
+* Fixing typo in metric description `error_total` (thanks to @dadadom) (#23)
 
 # v4.0.0 - 07 March 2018
 
 * Removing all deprecated metrics from 3.x release. This is a breaking change. Therefore bump to next major release.
-* Add additional label _terminal_ to all metrics of name _hystrix_command_event_total_. 
-Use this to identify if the event is a terminal event. #19
-* Marking _hystrix_command_total_ as deprecated. 
-Instead you should you should sum up all _hystrix_command_event_total_ with state "terminal" set to "true". #19
-* Marking _hystrix_command_error_total_ as deprecated.  
-Instead you should you should sum up all _hystrix_command_event_total_ with state "terminal" set to "true"
-that you consider errors in your scenarios. #19
+* Add additional label _terminal_ to all metrics of name _hystrix_command_event_total_. Use this to identify if the
+  event is a terminal event. #19
+* Marking _hystrix_command_total_ as deprecated. Instead you should you should sum up all _hystrix_command_event_total_
+  with state "terminal" set to "true". #19
+* Marking _hystrix_command_error_total_ as deprecated. Instead you should you should sum up all _
+  hystrix_command_event_total_ with state "terminal" set to "true"
+  that you consider errors in your scenarios. #19
 
 # v3.4.0 - 10 November 2017
 
@@ -33,13 +35,15 @@ that you consider errors in your scenarios. #19
 
 * Aiming to publish the command metrics Prometheus style (#4):
 
-    * histograms _hystrix_command_event_total_ and _hystrix_command_latency_total_ replace existing gauges _hystrix_command_latency_execute_percentile_XXX_ and _hystrix_command_latency_execute_XXX_. 
-    * counters _hystrix_command_total_ and _hystrix_command_error_total_ to replace the _hystrix_command_error_percentage_ gauge.
+    * histograms _hystrix_command_event_total_ and _hystrix_command_latency_total_ replace existing gauges _
+      hystrix_command_latency_execute_percentile_XXX_ and _hystrix_command_latency_execute_XXX_.
+    * counters _hystrix_command_total_ and _hystrix_command_error_total_ to replace the _
+      hystrix_command_error_percentage_ gauge.
     * _hystrix_command_event_total_ contains per event counters with the event type as a label to replace _hystrix_command_count_XXX_.
 
 * Co-exist with other Hystrix plugins like Spring Sleuth (#5)
 
 # v3.1.0 - 23 July 2017
 
-* Migrating from Gradle to Maven to have it in line with Prometheus Simple Client. 
+* Migrating from Gradle to Maven to have it in line with Prometheus Simple Client.
 * First release to Maven Central.

src/test/java/com/soundcloud/prometheus/hystrix/MetricsListTest.java

@@ -26,7 +26,10 @@ public void teardown() {
     @Test
     public void shouldWriteNiceMetricsOutput() throws IOException {
         // given
-        HystrixPrometheusMetricsPublisher.builder().shouldExportDeprecatedMetrics(false).buildAndRegister();
+        HystrixPrometheusMetricsPublisher.builder()
+                .shouldExportDeprecatedMetrics(false)
+                .shouldExportProperties(true)
+                .buildAndRegister();
         TestHystrixCommand command = new TestHystrixCommand("any");
 
         // when