Skip to content

Commit

Permalink
Fix migration of OVA to WFFC storage classes
Browse files Browse the repository at this point in the history
In a2170ea we've added the following logic: when using storage classes
that are set with WaitForFirstConsumer in migrations from vSphere, we
treat the PendingPopulation status as Succeeded since the conversion pod
would be the first consumer of the PVCs. This PR applies the same logic
also to migrations from OVA providers.

Signed-off-by: Arik Hadas <[email protected]>
  • Loading branch information
ahadas committed Jul 23, 2024
1 parent 1ae5f78 commit 70e206a
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/controller/plan/migration.go
Original file line number Diff line number Diff line change
Expand Up @@ -1506,7 +1506,9 @@ func (r *Migration) updateCopyProgress(vm *plan.VMStatus, step *plan.Step) (err
if !found {
continue
}
if dv.Status.Phase == cdi.PendingPopulation && r.Source.Provider.Type() == v1beta1.VSphere {
if dv.Status.Phase == cdi.PendingPopulation && r.Source.Provider.RequiresConversion() {
// in migrations that involve conversion, the conversion pod serves as the
// first consumer of the PVCs so we can treat PendingPopulation as Succeeded
dv.Status.Phase = cdi.Succeeded
}
conditions := dv.Conditions()
Expand Down

0 comments on commit 70e206a

Please sign in to comment.