Improvements to rpm-ch #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi,
Overall I tried to not add even more options to commands but rather have separate commands (likg gbp tag) since this makes it less confusing for users. |
What do you think it should commit? Just the changelog? I found it useful to be able to include other changes to the commit (by doing git-add before invoking gbp-rpm-ch)
Yes, I basically agree on that. However, the idea behind the committing/tagging options here is that you can automatically include the correct tag name in the changelog entry that you're committing/tagging. The rpm changlog entry has a version revision field and one option is to use the packaging tag there. |
marquiz
force-pushed
the
feature/rpm-ch
branch
from
b014201
to
d07ad16
Compare
Make it possible for git commands to output directly to stdout without redirection (i.e. capturing their stdout stream). Signed-off-by: Markus Lehtonen <[email protected]>
Previously the editor would not show in the shell because stdout was captured. Signed-off-by: Markus Lehtonen <[email protected]>
For setting the committer name/email/date - similarly to author_info. Signed-off-by: Markus Lehtonen <[email protected]>
For setting the committer name/email/date - similarly to author_info. Signed-off-by: Markus Lehtonen <[email protected]>
Commit the changes to Git. Using this option will commit the changelog modifications as well as all other staged changes, making it possible to easily include other changes in the commit, too. Signed-off-by: Markus Lehtonen <[email protected]>
Defines format string used to generate the commit message when --commit option is used. Signed-off-by: Markus Lehtonen <[email protected]>
Implement '--tag' command line option (and other related options for e.g. signing) for creating and tagging a release. These correspond the tagging options in gbp-buildpackage-rpm. A slight difference is that gbp buildpackage-rpm never commits anything to git. However, in rpm-ch the '--tag' option automatically enables --commit which causes the changelog modifications (and, all other staged changes) to be committed to git before creating the tag. This makes it possible to create a release and document the packaging/release tag name in the rpm changelog. Signed-off-by: Markus Lehtonen <[email protected]>
This option can be used to directly give the text for new changelog entry, skipping auto-generation from git commit history entirely. Thus, '--since' or '--all' do not have any effect when '--message' is defined. Signed-off-by: Markus Lehtonen <[email protected]>
If defined, rpm-ch uses all commits from the Git history. This can be useful when creating a new changelog from scratch. Using '--all' causes '--since' to be ignored. Signed-off-by: Markus Lehtonen <[email protected]>
This gives the user the possibility to define what meta tags (in git commit message) gbp-rpm-ch recognizes as bug tracking system references. Alternatively, it makes it possible to disable bts meta tag parsing altogether. Signed-off-by: Markus Lehtonen <[email protected]>
marquiz
force-pushed
the
feature/rpm-ch
branch
from
d07ad16
to
b14ee9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to run full unit tests on rpm based systems