refactor: simplified bundle variables code

agrostar · Jun 8, 2024 · 98ae00d · 98ae00d
1 parent a641c3a
commit 98ae00d
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/src/variableParser.ts b/src/variableParser.ts
@@ -62,16 +62,12 @@ export function loadVariables(
   if (!envName) return {};
 
   const allBundleVariables = getBundleVariables(bundleContent);
-  const bundleVars: Variables = allBundleVariables.hasOwnProperty(envName)
-    ? allBundleVariables[envName]
-    : {};
+  const bundleVars: Variables = allBundleVariables[envName] ?? {};
 
-  let envVars: Variables = {};
+  const envVars: Variables = {};
   varFileContents.forEach((fileContents) => {
     const parsedData = YAML.parse(fileContents);
-    if (parsedData && isDict(parsedData[envName])) {
-      Object.assign(envVars, parsedData[envName]);
-    }
+    if (parsedData && isDict(parsedData[envName])) Object.assign(envVars, parsedData[envName]);
   });
 
   const basicVars = Object.assign({}, envVars, bundleVars);