refactor: reducing nesting in getBundleVars and formatting w prettier

agrostar · May 27, 2024 · 2e1b657 · 2e1b657
1 parent f26c6e1
commit 2e1b657
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/variableParser.ts b/src/variableParser.ts
@@ -30,14 +30,12 @@ export function getBundleVariables(doc: string | undefined): Variables {
     throw new Error("Bundle could not be parsed. Is your bundle a valid YAML document?");
 
   const variables = parsedData.variables;
-  if (variables !== undefined) {
-    const error = checkVariables(variables);
-    if (error !== undefined) throw new Error(`error in variables: ${error}`);
+  if (variables === undefined) return {};
 
-    return variables;
-  } else {
-    return {};
-  }
+  const error = checkVariables(variables);
+  if (error !== undefined) throw new Error(`error in variables: ${error}`);
+
+  return variables;
 }
 
 export function getEnvironments(bundleContent: string | undefined, varFileContents: string[]): string[] {
@@ -58,7 +56,7 @@ export function getEnvironments(bundleContent: string | undefined, varFileConten
 export function loadVariables(
   envName: string | undefined,
   bundleContent: string | undefined,
-  varFileContents: string[]
+  varFileContents: string[],
 ): Variables {
   if (!envName) return {};