fix: encoded url on get_content (#51) (#52)

* fix: encoded url on get_content (#51) * ci: add manual moto install in CI * chore: black --------- Co-authored-by: Devarsh Bhatt <[email protected]> Co-authored-by: Tyler Matteson <[email protected]>
agritheory · May 6, 2024 · 0b0e8cb · 0b0e8cb
1 parent bf3133c
commit 0b0e8cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/frappe.yaml b/.github/workflows/frappe.yaml
@@ -80,6 +80,7 @@ jobs:
           bench new-site --db-root-password root --admin-password admin test_site
           bench --site test_site install-app cloud_storage
           bench build
+          bench pip install moto[s3]
         env:
           CI: 'Yes'
 

diff --git a/cloud_storage/cloud_storage/overrides/file.py b/cloud_storage/cloud_storage/overrides/file.py
@@ -21,6 +21,7 @@
 from magic import from_buffer
 from PIL import UnidentifiedImageError
 from werkzeug.datastructures import FileStorage
+from urllib.parse import quote
 
 FILE_URL = "/api/method/retrieve?key={path}"
 URL_PREFIXES = ("http://", "https://", "/api/method/retrieve")
@@ -181,7 +182,7 @@ def get_content(self) -> bytes:
 
 		if self.file_url:
 			self.validate_file_url()
-		file_path = self.get_full_path()
+		file_path = quote(self.get_full_path())
 
 		if self.is_remote_file:
 			client = get_cloud_storage_client()