Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command to switch to another wallet #18

Merged
merged 2 commits into from
Mar 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 34 additions & 9 deletions commands/keplr.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ let extensionId;
let extensionVersion;
let registrationUrl;
let permissionsUrl;
let walletsPageUrl;
let switchBackToCypressWindow;

const keplr = {
Expand All @@ -18,6 +19,7 @@ const keplr = {
extensionVersion = undefined;
registrationUrl = undefined;
permissionsUrl = undefined;
walletsPageUrl = undefined;
},
extensionId: () => {
return extensionId;
Expand All @@ -41,6 +43,9 @@ const keplr = {
async goToPermissions() {
await module.exports.goTo(permissionsUrl);
},
async goToWalletsPage() {
await module.exports.goTo(walletsPageUrl);
},
async switchToKeplrIfNotActive() {
if (playwright.isCypressWindowActive()) {
await playwright.switchToKeplrWindow();
Expand All @@ -55,12 +60,14 @@ const keplr = {
extensionVersion = keplrExtensionData.version;
registrationUrl = `chrome-extension://${extensionId}/register.html`;
permissionsUrl = `chrome-extension://${extensionId}/popup.html#/setting/security/permission`;
walletsPageUrl = `chrome-extension://${extensionId}/popup.html#/wallet/select`;

return {
extensionId,
extensionVersion,
registrationUrl,
permissionsUrl,
walletsPageUrl,
};
},
async disconnectWalletFromDapp() {
Expand All @@ -71,7 +78,12 @@ const keplr = {
);
return true;
},
async importWallet(secretWordsOrPrivateKey, password, newAccount) {
async importWallet(
secretWordsOrPrivateKey,
password,
newAccount,
walletName,
) {
await module.exports.goToRegistration();
await playwright.waitAndClickByText(
newAccount
Expand Down Expand Up @@ -105,14 +117,12 @@ const keplr = {
);
}

await playwright.waitAndType(
onboardingElements.walletInput,
onboardingElements.walletName,
);
await playwright.waitAndType(onboardingElements.walletInput, walletName);

const passwordFieldExists = await playwright.waitForAndCheckElementExistence(
onboardingElements.passwordInput,
);
const passwordFieldExists =
await playwright.waitForAndCheckElementExistence(
onboardingElements.passwordInput,
);

if (passwordFieldExists) {
await playwright.waitAndType(onboardingElements.passwordInput, password);
Expand Down Expand Up @@ -216,7 +226,7 @@ const keplr = {

async initialSetup(
playwrightInstance,
{ secretWordsOrPrivateKey, password, newAccount },
{ secretWordsOrPrivateKey, password, newAccount, walletName },
) {
if (playwrightInstance) {
await playwright.init(playwrightInstance);
Expand All @@ -234,8 +244,23 @@ const keplr = {
secretWordsOrPrivateKey,
password,
newAccount,
walletName,
);
},

async switchWallet({ walletName }) {
await module.exports.switchToKeplrIfNotActive();
frazarshad marked this conversation as resolved.
Show resolved Hide resolved
await module.exports.goToWalletsPage();

frazarshad marked this conversation as resolved.
Show resolved Hide resolved
await playwright.waitAndClickByText(
walletName,
playwright.keplrWindow(),
true,
frazarshad marked this conversation as resolved.
Show resolved Hide resolved
);
await playwright.switchToCypressWindow();

return true;
},
};

module.exports = keplr;
7 changes: 2 additions & 5 deletions pages/keplr/first-time-flow-page.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
const createWalletButton = 'Create a new wallet';
const existingWalletButton = 'Import an existing wallet';
const importRecoveryPhraseButton = 'Import existing recovery phrase';
const importRecoveryPhraseButton = 'Import existing recovery phrase';
const useRecoveryPhraseButton = 'Use recovery phrase or private key';
const phraseCount24 = '24 words';
const phrasePrivateKey = 'Private key';
const walletInput = 'input[name="name"]:focus';
const passwordInput = 'input[name="password"]';
const confirmPasswordInput = 'input[name="confirmPassword"]';
const walletName = 'My wallet';
const submitWalletDataButton = 'button[type="submit"]';
const phraseSelectChain = 'Select Chains';
const submitChainButton = 'button[type="button"]';
Expand All @@ -24,7 +23,6 @@ module.exports.onboardingElements = {
phraseCount24,
phrasePrivateKey,
walletInput,
walletName,
passwordInput,
confirmPasswordInput,
submitWalletDataButton,
Expand All @@ -33,6 +31,5 @@ module.exports.onboardingElements = {
phraseAccountCreated,
finishButton,
textAreaSelector,
submitChainButton,
submitPhraseButton,
};
};
9 changes: 8 additions & 1 deletion plugins/keplr-plugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,21 @@ module.exports = (on, config) => {
confirmTransaction: keplr.confirmTransaction,
rejectTransaction: keplr.rejectTransaction,
disconnectWalletFromDapp: keplr.disconnectWalletFromDapp,
setupWallet: async ({ secretWordsOrPrivateKey, password, newAccount }) => {
setupWallet: async ({
secretWordsOrPrivateKey,
password,
newAccount,
walletName,
}) => {
await keplr.initialSetup(null, {
secretWordsOrPrivateKey,
password,
newAccount,
walletName,
});
return true;
},
switchWallet: keplr.switchWallet,
});

return config;
Expand Down
6 changes: 6 additions & 0 deletions support/commands.js
Original file line number Diff line number Diff line change
Expand Up @@ -416,11 +416,13 @@ Cypress.Commands.add(
secretWordsOrPrivateKey = 'orbit bench unit task food shock brand bracket domain regular warfare company announce wheel grape trust sphere boy doctor half guard ritual three ecology',
password = 'Test1234',
newAccount = false,
walletName = 'My Wallet',
) => {
return cy.task('setupWallet', {
secretWordsOrPrivateKey,
password,
newAccount,
walletName,
});
},
);
Expand Down Expand Up @@ -452,3 +454,7 @@ Cypress.Commands.add('switchToExtensionWindow', () => {
Cypress.Commands.add('disconnectWalletFromDapp', () => {
return cy.task('disconnectWalletFromDapp');
});

Cypress.Commands.add('switchWallet', walletName => {
return cy.task('switchWallet', { walletName });
});
10 changes: 10 additions & 0 deletions tests/e2e/specs/keplr/keplr-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,27 @@ describe('Keplr', () => {
'orbit bench unit task food shock brand bracket domain regular warfare company announce wheel grape trust sphere boy doctor half guard ritual three ecology',
'Test1234',
true,
'My Wallet 2',
).then(setupFinished => {
expect(setupFinished).to.be.true;
});
});
it(`should complete Keplr setup by importing the wallet using private key`, () => {
cy.setupWallet(
'A9C09B6E4AF70DE1F1B621CB1AA66CFD0B4AA977E4C18497C49132DD9E579485',
null,
false,
'My wallet 3',
).then(setupFinished => {
expect(setupFinished).to.be.true;
});
});
it(`should switch to new wallet by name`, () => {
cy.switchWallet('My Wallet 2').then(taskCompleted => {
expect(taskCompleted).to.be.true;
});
// TODO: Add some more robust check later
});
it(`should disconnect the wallet from all the connected DAPPs`, () => {
cy.disconnectWalletFromDapp().then(taskCompleted => {
expect(taskCompleted).to.be.true;
Expand Down
Loading