ISP + NetSpeed

[dim]

Added geoip.isp + geoip.netspeed modules + tests.

[dim]

Update pushed. Thanks, D

[agladysh]

Thanks! Will merge and release on this week.

14.05.2013, â 12:16, Dimitrij Denissenko [email protected] íàïèñàë(à):

Update pushed. Thanks, D

—
Reply to this email directly or view it on GitHub.

[agladysh]

Sorry, I'm a little behind the schedule. Will try to do that ASAP.

On Wed, May 15, 2013 at 12:36 PM, Alexander Gladysh [email protected] wrote:

Thanks! Will merge and release on this week.

14.05.2013, в 12:16, Dimitrij Denissenko [email protected] написал(а):

Update pushed. Thanks, D

—
Reply to this email directly or view it on GitHub.

[convertstar]

Has this been merged anywhere? Does it work? Is this the only working implementation of Netspeed+ISP for lua?

[agladysh]

No, it is not merged yet. If you're interested, I'll try to clean it up in early November and release a new version.

[convertstar]

Very interested. We attempted a merge ourselves locally and while the result runs it appears to be having some weird memory related issues sometimes. We noticed that when doing a lot of lookups for netspeed or isp name that sometimes the lua environment it was being called from was having unrelated variables contents replaced with data from the maxmind lookup. Not sure how to debug that sort of thing just at the moment, unless there is something obviously wrong with the binding implementation on those other 2 databases.

[agladysh]

Ok. I should be able to get to this pull request in January (alas, the vacation time in November has passed). If you need it sooner, drop me a line to the e-mail in my profile, we'll discuss options :)