deps: update signature_pad to v4
#98
Conversation
Also remove the @types dependency as it appears signature_pad declares it's own types now.
aiden-jeffrey
force-pushed
the
aiden/update-signature-pad
branch
from
6241262 to
25920f2
Compare
agilgur5
added
scope: dependencies
There was a problem hiding this comment.
Thanks for making the PR, but unfortunately this does not address all the breaking changes in signature_pad v4. This effectively duplicates #68 as a result. Please see the detailed comments there for how this is a breaking change and what additional changes would need to be made to make react-signature-canvas compatible with it (which may require a major release).
So far, no contributor has made those changes, and actual feature requests for v4 have been very few and far in between.
agilgur5
changed the title
signature_pad to v4
| @@ -7,5 +7,7 @@ | |||
| "compilerOptions": { | |||
| // output to dist/ dir | |||
| "outDir": "dist/", | |||
| "jsx": "react-jsx", | |||
There was a problem hiding this comment.
so this is not compatible with older React versions, which is why I have yet to use it and why I still have import React (among other things). you might notice that in the peerDeps here, react-signature-canvas is backward compatible with at least React v14.
this would require changing the peerDeps version. it looks like the React team did backport this all the way to React v14, but the range would need to be changed to only those versions and above, i.e. ^16.14.0, ^15.7.0, ^0.14.10 (and 17+ ofc)
| @@ -7,5 +7,7 @@ | |||
| "compilerOptions": { | |||
| // output to dist/ dir | |||
| "outDir": "dist/", | |||
| "jsx": "react-jsx", | |||
| "importsNotUsedAsValues": "preserve" | |||
There was a problem hiding this comment.
I don't think this is needed as all of the imports are still used even when the types are removed. Is there a reason you added this?
| import { Options as SignaturePadOptions } from 'signature_pad' | ||
| import SignaturePad from 'signature_pad' |
There was a problem hiding this comment.
| import { Options as SignaturePadOptions } from 'signature_pad' | |
| import SignaturePad from 'signature_pad' | |
| import SignaturePad, { Options as SignaturePadOptions } from 'signature_pad' |
I would prefer to keep imports of the same library on the same line (and generally avoid stylistic changes)
| @@ -158,7 +159,7 @@ export class SignatureCanvas extends Component<SignatureCanvasProps> { | |||
| } | |||
|
|
|||
| toDataURL: SignaturePad['toDataURL'] = (type, encoderOptions) => { | |||
| return this.getSignaturePad().toDataURL(type, encoderOptions) | |||
| return this.getSignaturePad().toDataURL(type as string, encoderOptions as number) | |||
There was a problem hiding this comment.
why was this type-cast necessary? we should have the exact same types and not force any subset
|
Closing as stale with no response in 2 weeks. Can re-open if this is picked back up |
Also remove the @types dependency as it appears signature_pad declares it's own types now.