Standardize test config, upgrade (some) devDeps, add named export #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- have been putting tests separately from source nowadays in other of my libraries, so standardize around that - put fixtures just in test/ (later could be in test/fixtures/), leave config/ solely for test config type things
- basically the same one I use in all my other libraries - I believe it's an old version of Node output from gitignore.io iirc - it has comments unlike the old one, so that's much nicer for those who aren't totally sure what each entry is for
- no more globals used in tests!
- Node 8 was EOL in December, I upgraded locally a while ago too - The default NPM version for Node v10 also supports `npm ci`, which should be a CI speed boost as well
- because canvas@1 is deprecated and is having install issues
- see hhttps://travis-ci.org/agilgur5/react-signature-canvas/builds/650962136,
https://travis-ci.org/agilgur5/react-signature-canvas/builds/658062587,
etc
- because many folks prefer not to use default exports and because named exports are more explicit, etc, etc
- 'build' is a lot more intuitive and matches other usage
- and import & use it here!
- now that GH officially supports branch renames, moving all my repos
to use `main`
- GH also creates redirects now, which seem to be working well for
the badges right now, but better to move all of them anyway
- also had to switch Codecov default branch etc
- https://blog.travis-ci.com/2021-05-07-orgshutdown - made the switch over with my last PR, but needed to change the docs too - update badge to use `.com` - update link to use `.com`, `app.` subdomain, and `github/` URL that travis-ci.com currently uses - also use `/branches` URL as the default URL shows current builds, which includes WIP PR/branch builds too - `/branches` shows the "default branch" first instead and various checkmarks etc, so it's a good summary page that can be drilled down from
agilgur5
added
kind: feature
agilgur5
commented
Feb 10, 2022
|
Tests are passing on the CI branch build, but for some reason no PR build was triggered. Should be good to merge but I'll have to temporarily modify the status checks to do so (as I don't believe I can get Travis to re-trigger a PR build, only branches afaik) |
Repository owner
locked as resolved and limited conversation to collaborators
Feb 11, 2022
agilgur5
added
the
scope: tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
History
Basically all of these commits were authored 2 years ago (just rebased them, so commit time is different from authored time) while I was standardizing various aspects of my library set-up in several different repos I maintain (really need a codemod tool or something for this like
mrm).I never got to finishing it up or PR'ing it, and honestly I don't remember why. Usually it's because I get stuck on something, but I tried looking through my old code and honestly wasn't sure. I was very busy with a new job, the pandemic (Feb 2020), and maintaining TSDX, so might've just been a time constraint 🤷 . #42 was partially blocked on this as well.
The two most recent (tiny) docs commits I just made.
Changes
mainbranch as defaultReview Notes
Yes, some of these deps are (once again) outdated now (e.g. Node 10 was EOL April 2021), but this is supposed to be merged before #42 which itself now has various out-of-date deps. So will wait for after/when that is merged to upgrade those.