Replace Tocbot with functionality from Bootstrap and remove jQuery #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why ship Tocbot if Bootstrap can do it already? Also see https://getbootstrap.com/docs/5.3/components/scrollspy/ for reference.
svg.jquery.js isn't needed for pygal >= 2, see Kozea/pygal#250 (comment)
FestplattenSchnitzel
force-pushed
the
bt_scrollspy
branch
from
ad0a9fb
to
d524904
Compare
FestplattenSchnitzel
force-pushed
the
bt_scrollspy
branch
from
75bbc88
to
304034f
Compare
lukasjuhrich
changed the title
lukasjuhrich
requested changes
Feb 24, 2024
There was a problem hiding this comment.
See my comment regarding tocbot; Please create separate PRs for
- jQuery removal (Evaluate dropping jQuery #488) this is obviously useful, especially the svg part (250kB!)
- JS cleanup (minification; Ship minified versions of htmx and pygal-tooltips #489)
Re minification, I wanted to complain that you didn't include source maps, but neither pygal nor htmx provide those. Not ideal, but solving this would require a build step for sipa where we minify and gzip things ourselves. That can / should be tackled separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why ship Tocbot if Bootstrap can do it already?
Also see https://getbootstrap.com/docs/5.3/components/scrollspy/ for
reference.