-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat 1256 runner to not use meetup api to display events #1335
Merged
agallou
merged 10 commits into
afup:master
from
vinceAmstoutz:feat-1256-runner-to-not-use-meetup-api-to-display-events
Nov 26, 2023
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6e621f3
build: rm dms/meetup-api-client dependency no longer required
vinceAmstoutz 8a001e9
feat: replace the runner source to use the db & not the meetup.com api
vinceAmstoutz b52b8c3
fix: restore transformer
vinceAmstoutz cb5e668
Merge branch 'master' of https://github.com/vinceAmstoutz/afup-web in…
vinceAmstoutz 1cbb28f
feat: edit tranformer to work with the newtest afup_meetup db
vinceAmstoutz 53aa2ce
feat: improve runner to run scrapping meetups command and improve output
vinceAmstoutz 2a47f87
feat: adapt meetup index command using afup_meetup table
vinceAmstoutz 1854972
feat: restore isUpcoming event using a comparison
vinceAmstoutz dd712aa
feat: adapt transformer testing to the new method
vinceAmstoutz bd48142
fix: remove residues
vinceAmstoutz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pour moi il faut conserver l'appel au transformer. Le format de ce qu'on envoie à Algolia doit toujours être celui-ci :
web/sources/AppBundle/Indexation/Meetups/Transformer.php
Line 27 in d4d449d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok je modifie ça à l'occasion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C'est fait j'ai restoré le
transformer
par contre j'ai des doutes sur le faite qu'il fasse lui passerOfficesCollections
à l'instanciation. Le contenu de la méthodetransform
me parait également peut adapté puis qu'on a un tableau d'objet Meetups désormais à traiter. Comment puis-je tester tout ca @agallou ? En modifianttests/units/AppBundle/Indexation/Meetups/Transformer.php
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Le plus simple que je vois est de se créer un compte de test sur Algolia.
De modifier les paramètres lié à algolia dans le parameters.yml :
web/app/config/parameters.yml.dist-docker
Line 20 in 6c24a04
Et de relancer
indexing:meetups
.Et ensuite aller voir cette page en local : https://afup.org/meetups/
Pour moi le officesCollection peux rester, il permet d'en récupérer les libellés, mais effectivement il faut adapter le transformer pour non plus traiter un tableau qui viens de l'API meetup, mais de la base de données.
(au besoin si tu veux on peux s'appeler si ça peux être plus clair)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Je re-regarde ca dès que possible et je te redis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Voilà c'est fait @agallou 🙂