Remove inspector component to properly unregister keydown listener #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the inspector is loaded via a script tag otherwise the listener will be registered twice and we can't toggle the inspector from viewer mode with the shortcut.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove inspector component to properly unregister the keydown listener registered in the inspector component when the inspector is loaded via a script tag like here
aframe-inspector/examples/index.html
Line 64 in a9901b9
otherwise the listener will be registered twice and we can't toggle the inspector from viewer mode with the shortcut (it will toggle the inspector and toggle back to viewer mode right away)
When loaded via script tag, removeEventListeners is not executed
https://github.com/aframevr/aframe/blob/9cdc30465247685a69067eb5beb0d177367eebc9/src/components/scene/inspector.js#L104
removing the component will execute removeEventListeners
https://github.com/aframevr/aframe/blob/9cdc30465247685a69067eb5beb0d177367eebc9/src/components/scene/inspector.js#L57