Fix TextureWidget componentDidUpdate to not crash React UI on aframe 1.6.0 #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Note this PR is okay to be merged, it doesn't crash anymore when you select an entity with a texture, but there is still an issue of changing the texture that's being discussed in #722 |
|
Okay, I just verified with aframe master by copying a build manually, the issue of changing the texture on the cube is definitely fixed with both this change and the changes from aframevr/aframe#5544 |
|
I'm confirming aframevr/aframe#5549 fixes the issue of removing the texture on the cube. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #722