[cleanup] Remove unneeded child-attached listener that refreshes raycaster objects #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aster component before cursor
2 tasks
vincentfretin
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove child-attached listener that refreshes raycaster objects.
I really don't see why this code is there. It was introduced in 63e2e1a
Around that time aframevr/aframe@a463d64 changed raycaster component where events were changed from loaded/child-attached/child-detached to object3dset/object3dremove
It doesn't make sense to me to have here child-attached listener but not child-detached.
Removing the listener doesn't change anything, all is still working properly as far as I can see.
I guess it was related to 'a-scene :not([data-aframe-inspector])' selector that was probably not working on all browsers at that time?
And because raycaster component is a dependency of cursor, it's better to set raycaster first and then cursor.