Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added this.emit = Events.emit to add possibility to emit custom events from outside the Inspector class. #719

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

gregogalante
Copy link
Contributor

Added this.emit = Events.emit to add possibility to emit custom events from outside the Inspector class.

Added this.emit = Events.emit to add possibility to emit custom events from outside the Inspector class.
@vincentfretin
Copy link
Contributor

It would make sense to also expose this.off = Events.off; so you can remove a listener you added previously with AFRAME.INSPECTOR.on. (Ok just saw you added it)

@vincentfretin
Copy link
Contributor

I would be interested of knowing your use case with this, creating entity with the entitycreate event maybe? You can DM me on discord (handle vincentfretin) for a quick chat.
I myself have the whole aframe-inspector code in my own repo under src/editor. This is also what 3dstreet is doing now, so we're just importing Events. We're also working on a new json import/export of the scene, see 3DStreet/3dstreet#537

@dmarcos
Copy link
Member

dmarcos commented Jun 7, 2024

Thanks so much. Congrats on your first contribution @gregogalante

@vincentfretin
Copy link
Contributor

Did you forgot to push the Merge button @dmarcos?

@dmarcos dmarcos merged commit 9302f2a into aframevr:master Jun 12, 2024
1 check passed
@dmarcos
Copy link
Member

dmarcos commented Jun 12, 2024

thanks

@vincentfretin
Copy link
Contributor

This was not working. It will be reverted in #755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants