Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Actions #217

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Frontend Actions #217

merged 2 commits into from
Oct 2, 2023

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Sep 27, 2023

Proposed changes

This adds a CI step for building and committing the frontend to the repo if necessary after performing a git status .

Also changed the workflows to use the reusable workflows / actions where appropriate.

Types of changes

What types of changes does your code introduce? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionalitiy)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you are unsure about any of the choices, don't hesitate to ask!

  • Changes have been tested to ensure that fix is effective or that a feature works.
  • Changes pass the unit tests
  • Code has been run through black with the -l 79 flag.
  • I have included necessary documentation or comments (as necessary)
  • Any dependent changes have been merged and published

Notes

All PRs will undergo the unit testing before being reviewed. You may be requested to explain or make additional changes before the PR is accepted.

PR template was adopted from appium

@kaitj kaitj added the enhancement New feature or request label Sep 27, 2023
@kaitj kaitj linked an issue Sep 27, 2023 that may be closed by this pull request
@kaitj
Copy link
Collaborator Author

kaitj commented Sep 27, 2023

Need to make commit optional depending on status check

@kaitj kaitj merged commit 2fa1a37 into afids:master Oct 2, 2023
8 checks passed
@kaitj kaitj deleted the maint/actions branch October 2, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI for frontend
2 participants