Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[F003] Dashboard layout #7

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

[F003] Dashboard layout #7

wants to merge 12 commits into from

Conversation

aetheryna
Copy link
Owner

@aetheryna aetheryna commented Jun 21, 2022

What happened

Created the dashboard layout. 👷🏾

Insight

Created UI tests using cypress for checking the header and navigation.

Proof Of Work

image
image

image
image

image
image

@aetheryna aetheryna requested a review from bterone June 21, 2022 09:14
@aetheryna aetheryna force-pushed the feature/f003-dashboard branch from 6db1014 to 8f29015 Compare June 22, 2022 14:42
Copy link
Collaborator

@bterone bterone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also write some tests, like testing element visibility when user is logged in vs not logged in, the setPageTitle helper etc

src/components/NavigationBarAside.tsx Outdated Show resolved Hide resolved
styles/components/_header-lobby.scss Outdated Show resolved Hide resolved
src/components/NavigationBarAside.tsx Outdated Show resolved Hide resolved
@bterone bterone self-requested a review June 26, 2022 11:46
@aetheryna
Copy link
Owner Author

We should also write some tests, like testing element visibility when user is logged in vs not logged in, the setPageTitle helper etc

I didn't test it there because I wasn't using redux, originally redux is supposed to be in use so its gonna be tested in the next feature when redux is actually being used and authentification is handled. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants