Merge pull request #13 from davidwessman/wrapping-testsuites

Adds a wrapping <testsuites> to adhere to standard
aespinosa · Mar 21, 2024 · f0ceb24 · f0ceb24
2 parents c3eed68 + fb38d75
commit f0ceb24
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/minitest/junit.rb b/lib/minitest/junit.rb
@@ -33,6 +33,7 @@ def report
         instruct[:version] = '1.0'
         instruct[:encoding] = 'UTF-8'
         doc << instruct
+
         testsuite = Ox::Element.new('testsuite')
         testsuite['name'] = @options[:name] || 'minitest'
         testsuite['timestamp'] = @options[:timestamp]
@@ -46,7 +47,10 @@ def report
           testsuite << format(result)
         end
 
-        doc << testsuite
+        testsuites = Ox::Element.new('testsuites')
+        testsuites << testsuite
+
+        doc << testsuites
         @io << Ox.dump(doc)
       end
 

diff --git a/test/reporter_test.rb b/test/reporter_test.rb
@@ -14,7 +14,7 @@ def test_no_tests_generates_an_empty_suite
     reporter.report
 
     assert_match(
-      %r{<?xml version="1.0" encoding="UTF-8"\?>\n<testsuite name="minitest" timestamp="[^"]+" hostname="[^"]+" tests="0" skipped="0" failures="0" errors="0" time="0.000000"\/>},
+      %r{<?xml version="1.0" encoding="UTF-8"\?>\n<testsuites>\n  <testsuite name="minitest" timestamp="[^"]+" hostname="[^"]+" tests="0" skipped="0" failures="0" errors="0" time="0.000000"\/>\n<\/testsuites>\n},
       reporter.output
     )
   end