Add mixins #5
Merged
Add mixins #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first draft implementation. Unit testing can now begin...
This should allow accepting ClassDecorator as argument(s) for other mixin related functions / utils.
Found ref. to mozilla's documentation of "abstract subclass or mix-in"...
Still not really applicable when defining a mixin, but still accepted by the @mixin decorator.
Mixins must be applied on the "parent" class, if any is available such that the target class still can overwrite methods defined in a mixin.
This seems to be problematic, because we are dynamically extending the target. Need to find correct way of doing this, such that super() calls can work.
Naming seems more convenient now.
The attempt was good, but it seems impossible to respect true class inheritance via the class decorator. For this reason, the original Mixin Builder (mix -> with) component should be adapted / ported into this submodule instead.
Class decorator and tests will be removed, as soon as the original Mixin Builder component has been implemented.
Has now been replaced with the original mix() / Mixin Builder component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds the
@aedart/support/mixinssubmodule. It offers an adaptation of Justin Fagnani'smixwith.js.Details
See additional details in
CHANGELOG.ms