Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change BidResponse.ext to be a JsonElement #155

Merged
merged 5 commits into from
Aug 15, 2024
Merged

change BidResponse.ext to be a JsonElement #155

merged 5 commits into from
Aug 15, 2024

Conversation

renam
Copy link
Contributor

@renam renam commented Aug 14, 2024

No description provided.

Copy link
Contributor

@standa-dev standa-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might also be good to test when the use_new_renderer is missing or false

Copy link
Member

@JasonSznol JasonSznol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the suggestion @marcsantiago made about strongly typing the ext field is a safer approach and does not have the trade off of coupling the deserialization with Json; for comparison both iOS and the Go module in this repo are using strongly typed ext objects.

In some future if we wanted to make this more generic we can leverage contextual serialization and define the ext field serializer within the request module of the SDK to avoid having to make updates in this module should the ext field change again.

@renam renam requested review from standa-dev and JasonSznol August 14, 2024 20:05
@renam renam merged commit a56520b into main Aug 15, 2024
1 check passed
@renam renam deleted the fix/bid-response branch August 15, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants