-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change BidResponse.ext to be a JsonElement #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might also be good to test when the use_new_renderer
is missing or false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the suggestion @marcsantiago made about strongly typing the ext field is a safer approach and does not have the trade off of coupling the deserialization with Json; for comparison both iOS and the Go module in this repo are using strongly typed ext objects.
In some future if we wanted to make this more generic we can leverage contextual serialization and define the ext field serializer within the request module of the SDK to avoid having to make updates in this module should the ext field change again.
No description provided.