Allow passing a function for command arguments #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisanthropicBit
force-pushed
the
custom-mocha-arguments
branch
from
7fea22d to
0e8d40c
Compare
MisanthropicBit
force-pushed
the
custom-mocha-arguments
branch
from
b1d3d35 to
d03e1fa
Compare
|
Hey @adrigzr. Apologies but I can't merge this PR either due to the same reason as #15. Again, if you agree with the changes of course 🙂 This might also help fix #16 since you could pass a custom reporter that writes the test output to a json file instead of stdout for older versions of mocha. In that regard, I've updated the README to include a requirement of mocha 9.1.0+ to have support for writing the test output to a json file via the json reporter. |
|
Sure, @MisanthropicBit! Thanks for your contributions 😄 |
|
@MisanthropicBit gonna test to see if it solves the issue! |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12.
I decided to only allow a function as an argument as passing a
string[]directly wouldn't have the context of aresults_pathetc. Also since thecommandoption is split on "%s+" which breaks strings like--grep='this is a test pattern', I thought this would be more flexible.