feature: add support for oidc-provider@8
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do you plan to release this feature any soon? |
Added support for `oidc-provider@8` which became ESM-only. Support is done through dynamic import of the `oidc-provider` package as Nest does not support ESM-only packages directly, as it only compiles for CJS.
Using `new Function` was causing unexpected errors in jest tests
adrianbrs
force-pushed
the
feature/oidc-provider-v8
branch
from
28b2b19
to
097c04c
Compare
This new decorator makes it easy to retrieve the current user session from the context
This version of `oidc-provider` exports the Provider as a named export. The latest version of the `@types` package also includes the previously missing typings. BREAKING CHANGE: The `InteractionDetails` type has been renamed to `Interaction` and is now exported directly from `oidc-provider`.
adrianbrs
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, version 8 of
oidc-provideris not supported as it is now ESM-only, and NestJS still does not support ESM-only packages as it builds only for CJS, generating an error [ERR_REQUIRE_ESM] when importing theoidc-providerlibrary.Issue Number: #22
What is the new behavior?
ESM-only versions of
oidc-providerare now supported through dynamic imports. The only limitation is that you cannot import anything from theoidc-providerlibrary directly, but only through the dependency injection provided by this package.Does this PR introduce a breaking change?
Some important changes must be made for this new version to work:
oidc-providerlibrary must be removedoidc-providerinstance or other module exposuresOidcnamespace, and now all decorators are prefixed withOidc, for example:@OidcContext.InteractionDetailstype has been renamed toInteractionand is now exported directly fromoidc-provider.