Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #56

Closed
wants to merge 5 commits into from
Closed

Update index.md #56

wants to merge 5 commits into from

Conversation

azarboon
Copy link
Contributor

@azarboon azarboon commented Oct 22, 2024

I would suggest to add a template so beginners have an easier time onboarding ADR. Because it can be overwhelming for a beginner to consume listed materials. I've added a suggested template based on Mark Richard's video: https://www.youtube.com/watch?v=LMBqGPLvonU

I would suggest to add a template so beginners have an easier time onboarding ADR. I've added a suggested template based on Mark Richard's video: https://www.youtube.com/watch?v=LMBqGPLvonU
@koppor
Copy link
Member

koppor commented Oct 24, 2024

we should not add another template 😅

why not simply using https://github.com/adr/madr/blob/develop/template%2Fadr-template-minimal.md

@azarboon
Copy link
Contributor Author

azarboon commented Oct 24, 2024

we should not add another template 😅

why not simply using https://github.com/adr/madr/blob/develop/template%2Fadr-template-minimal.md

Is this mentioned in the main page? If so, where exactly? I searched for it but couldn't find it.

@azarboon
Copy link
Contributor Author

I create a new PR to improve the existing template. I believe the template should be referenced in the main page and also MADR, be explained a bit more. I will make some changes soon.

@koppor
Copy link
Member

koppor commented Oct 24, 2024

I create a new PR to improve the existing template. I believe the template should be referenced in the main page and also MADR, be explained a bit more. I will make some changes soon.

We did reference - but the length is a bit short:

image

Updates very welcome! A verbatim copy sounds great!

@koppor
Copy link
Member

koppor commented Oct 24, 2024

MADR currently offers four variants - I am not sure which variant to prominently present. I do not want to confuse readers.

Maybe, we should just present the full template: https://github.com/adr/madr/blob/develop/template/adr-template.md?plain=1. The bare https://github.com/adr/madr/blob/develop/template/adr-template-bare.md?plain=1 has all of it, but without guidance. Maybe, we need a mix of both? Not sure if we should extend bare (and keep the name) or add an additional variant 😅.

Refs adr/madr#168

Refined the page, a bit. Made it more coherent, and clear. I think its now easier for a beginner to make sense of this page.
@azarboon
Copy link
Contributor Author

MADR currently offers four variants - I am not sure which variant to prominently present. I do not want to confuse readers.

Maybe, we should just present the full template: https://github.com/adr/madr/blob/develop/template/adr-template.md?plain=1. The bare https://github.com/adr/madr/blob/develop/template/adr-template-bare.md?plain=1 has all of it, but without guidance. Maybe, we need a mix of both? Not sure if we should extend bare (and keep the name) or add an additional variant 😅.

Refs adr/madr#168

Thanks for explanation. Despite your instruction, it took me awhile to make sense of the page. I refined it a bit. I believe its now more coherent, and easier for a beginner to navigate and to make sense of.

@azarboon
Copy link
Contributor Author

azarboon commented Oct 24, 2024

Also that mentioned Technology Radar volume is 6 years old. I dont think its relevant anymore so I removed it.

Copy link
Contributor

@socadk socadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minimal MADR template is quite close to the Nygardian ADR template, no need to position it as an alternative.

Removed Nygardian ADR template.
@azarboon
Copy link
Contributor Author

azarboon commented Oct 24, 2024

The minimal MADR template is quite close to the Nygardian ADR template, no need to position it as an alternative.

Agreed. Removed it.

Renamed the other section for better clarity. Removed the redundant link
@azarboon
Copy link
Contributor Author

I retitled the other section for better brevity. I'm open for better suggestions.

Also, I removed redundant links. This can make the overall page to be more reader-friendly.

Added the link to MADR so readers have it easier to navigate. In my previous edits, I removed the link so hereby, I'm refining it.
@azarboon
Copy link
Contributor Author

@koppor @socadk FYI: I've added the link to this project in Azure Documentation. So in their official page for ADR, they are referring to only this project for further info.

@azarboon
Copy link
Contributor Author

any update on this PR? I believe now it's easier to understand. Can you please approve it?

@koppor
Copy link
Member

koppor commented Oct 28, 2024

any update on this PR? I believe now it's easier to understand. Can you please approve it?

We changed the layout of the page (#58). - We are working on better sections. Thereby, we will try to use some of your updated texts. Let's see, how everything goes...

We also saw that you removed "MADR" from the list of "Collection of ADR Templates". - The whole section is a bit unstructured - with the update, it should get better...

@azarboon
Copy link
Contributor Author

any update on this PR? I believe now it's easier to understand. Can you please approve it?

We changed the layout of the page (#58). - We are working on better sections. Thereby, we will try to use some of your updated texts. Let's see, how everything goes...

We also saw that you removed "MADR" from the list of "Collection of ADR Templates". - The whole section is a bit unstructured - with the update, it should get better...

OK. Please update me when you are done. Once we finalize this PR, we can work on other one.

@koppor
Copy link
Member

koppor commented Oct 30, 2024

OK. Please update me when you are done. Once we finalize this PR, we can work on other one.

We are done now. Hope, you like the new appearance. Especially https://adr.github.io/adr-templates/.

(The chosen Template was the only one I found looking nice, lean, and maintainable - and I spend hours on this - I am aware that we don't get a TOC on the hompage on the right; but we accept it - cotes2020/jekyll-theme-chirpy#2015).


All in all thank you for your text suggestions and we hope you like how they were incorporated in the new homepage.

@koppor koppor closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants