Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tools.jar dependency from TKG #633

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

annaibm
Copy link
Contributor

@annaibm annaibm commented Oct 29, 2024

This PR removes the tools.jar dependency from TKG due to the following updates in related repositories:

  • aqa-tests: Updated to use JDK 17 (instead of JDK 8) to build system test-related jars (PR 5711).
  • STF: Modified to use tools.jar from the java.home/lib directory (adoptium/STF#140).

related: eclipse-openj9/openj9#19888

@llxia
Copy link
Contributor

llxia commented Nov 18, 2024

Please update the PR title to reflect the change in the PR and reference the related issue.

@annaibm annaibm changed the title Testmauve Remove tools.jar dependency download from system testDependency directory Nov 18, 2024
@annaibm annaibm changed the title Remove tools.jar dependency download from system testDependency directory Remove tools.jar dependency from TKG Nov 18, 2024
- Remove the download of tools.jar into testDependency dir in the system
- The tools.jar locaton is updated to be taken from java.home lib in STF

related: eclipse-openj9/openj9#19888

Signed-off-by: Anna Babu Palathingal <[email protected]>
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia
Copy link
Contributor

llxia commented Nov 18, 2024

ToDo: we need to clean up pre-staged system test libs on the machines

@annaibm annaibm marked this pull request as ready for review November 18, 2024 18:32
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 1cd98d0 into adoptium:master Nov 18, 2024
3 checks passed
@llxia
Copy link
Contributor

llxia commented Nov 18, 2024

Cleanup_Test_Lib

@llxia
Copy link
Contributor

llxia commented Nov 18, 2024

Cleanup_Test_Lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants