Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump electron-forge to 5.2.4 #383

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

mnutt
Copy link
Contributor

@mnutt mnutt commented Mar 10, 2019

This upgrades electron-forge to the latest version, which I believe will fix this issue on MacOS:

electron/packager#927

@bendemboski
Copy link
Member

Hey @jacobq I know #358 is something we'd still love to get back to, but since this is green right now, any objection to merging?

@jacobq
Copy link
Collaborator

jacobq commented Apr 9, 2019

@bendemboski Sorry, not sure how I missed this. I have no objections. In fact, I have been using yarn selective resolutions to force this behavior in my projects for a while now so that I can use Electron versions newer than the latest published electron-prebuilt-compile package (like this).

@jacobq jacobq merged commit 069ca9d into adopted-ember-addons:master Apr 9, 2019
@bendemboski
Copy link
Member

🎉 This PR is included in version 2.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants